security
/
fortify
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

app/run: remove bare launch option 

This flag serves no use and is only a leftover from Ego.

Signed-off-by: Ophestra Umiker <cat@ophivana.moe>
This commit is contained in:
Ophestra Umiker 2024-09-09 00:32:17 +09:00
parent 83af555c97
commit 7450b0b0bb
Signed by: cat
SSH Key Fingerprint: SHA256:gQ67O0enBZ7UdZypgtspB2FDM1g3GVw8nX0XSdcFw8Q
2 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cli.go
View File

@ -28,7 +28,6 @@ func init() {
flag.BoolVar(&app.LaunchOptions[app.LaunchMethodSudo], "sudo", false, "Use 'sudo' to switch user") flag.BoolVar(&app.LaunchOptions[app.LaunchMethodSudo], "sudo", false, "Use 'sudo' to switch user")
flag.BoolVar(&app.LaunchOptions[app.LaunchMethodMachineCtl], "machinectl", true, "Use 'machinectl' to switch user") flag.BoolVar(&app.LaunchOptions[app.LaunchMethodMachineCtl], "machinectl", true, "Use 'machinectl' to switch user")
flag.BoolVar(&app.LaunchOptions[app.LaunchBare], "bare", false, "Only set environment variables for child")
flag.BoolVar(&flagVerbose, "v", false, "Verbose output") flag.BoolVar(&flagVerbose, "v", false, "Verbose output")
flag.BoolVar(&printVersion, "V", false, "Print version") flag.BoolVar(&printVersion, "V", false, "Print version")

12
internal/app/run.go
View File

@ -20,7 +20,6 @@ const (
LaunchMethodSudo = iota LaunchMethodSudo = iota
LaunchMethodMachineCtl LaunchMethodMachineCtl
LaunchBare
launchOptionLength launchOptionLength
) )
@ -59,10 +58,10 @@ func (a *App) Run() {
} }
if system.V.Verbose { if system.V.Verbose {
fmt.Printf("Selected launcher '%s' bare=%t\n", toolPath, LaunchOptions[LaunchBare]) fmt.Printf("Selected launcher '%s'\n", toolPath)
} }
cmd := exec.Command(toolPath, commandBuilder(LaunchOptions[LaunchBare])...) cmd := exec.Command(toolPath, commandBuilder()...)
cmd.Env = a.env cmd.Env = a.env
cmd.Stdin = os.Stdin cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout cmd.Stdout = os.Stdout
@ -99,7 +98,7 @@ func (a *App) Run() {
os.Exit(r) os.Exit(r)
} }
func (a *App) commandBuilderSudo(bare bool) (args []string) { func (a *App) commandBuilderSudo() (args []string) {
args = make([]string, 0, 4+len(a.env)+len(a.command)) args = make([]string, 0, 4+len(a.env)+len(a.command))
// -Hiu $USER // -Hiu $USER
@ -123,7 +122,7 @@ func (a *App) commandBuilderSudo(bare bool) (args []string) {
return return
} }
func (a *App) commandBuilderMachineCtl(bare bool) (args []string) { func (a *App) commandBuilderMachineCtl() (args []string) {
args = make([]string, 0, 9+len(a.env)) args = make([]string, 0, 9+len(a.env))
// shell --uid=$USER // shell --uid=$USER
@ -158,14 +157,11 @@ func (a *App) commandBuilderMachineCtl(bare bool) (args []string) {
innerCommand := strings.Builder{} innerCommand := strings.Builder{}
if !bare {
innerCommand.WriteString("dbus-update-activation-environment --systemd") innerCommand.WriteString("dbus-update-activation-environment --systemd")
for _, e := range a.env { for _, e := range a.env {
innerCommand.WriteString(" " + strings.SplitN(e, "=", 2)[0]) innerCommand.WriteString(" " + strings.SplitN(e, "=", 2)[0])
} }
innerCommand.WriteString("; ") innerCommand.WriteString("; ")
//innerCommand.WriteString("systemctl --user start xdg-desktop-portal-gtk; ")
}
if executable, err := os.Executable(); err != nil { if executable, err := os.Executable(); err != nil {
state.Fatal("Error reading executable path:", err) state.Fatal("Error reading executable path:", err)